"Only Bayer-pattern RAW files supported, sorry...."
Recent Samsung DNGs are not CFA, but "enhanced" 3-channel LinerRaw (like recent Apple iPhone ProRAW), and w/ ljpeg compression using restart markers...
Recent Samsung models started putting out the "less" normal DNGs - the ljpeg compression is not a single stream, but has restart markers, don't know if LibRaw supports that...
Yes, RawDigger relies on LibRaw imgdata.idata.filters to get CFA layout. Also, if LibRaw CFA pattern/layout detection is wrong it will result into a wrong rendering.
thank you for your swift reply. OK, I understand. I mainly use MATLAB (R2022a) -which uses LibRaw- but encountered the issue of not being able to open GPR files. That is why I started to delve into the LibRaw *.exe files. So I will wait until the next MATLAB release (R2023a). Maybe they then support GoPro's GPR files.
As for metadata, I use Exiftool extensively but found the MATLAB implementation of getting RAW metadata (again using LibRaw) faster than my code (which also needs to call Exiftool). However, for a Nikon P6000 file, the CFA layout delivered by MATLAB is different from the one given in Exiftool. And since I also have RAWdigger and see that the individual channels are displayed correctly, I wondered where the error comes from. That was my reason to ask if there would be a LibRaw *.exe file to extract metadata.
If it would be a LibRaw error, then RAWdigger would display the channels wrongly, I guess. But also a MATLAB error seems strange as they use LibRaw.
If you want, I could send you the file. Many thanks for what you do and for spreading your knowledge!
Cheers
What metadata you're asking for? Probably it is better to use exiftool for it.
Providing LibRaw binaries with 3rd-party decoders/decompressors compiled in (libjpeg, libdeflate/libz, libjasper, Adobe DNG SDK, GoPro SDK) may result into 3rd-party libraries version conflicts: for example LibRaw uses libjpeg-turbo, while calling applications is linked with standard jpeg libraries.
So, the developer who uses LibRaw should select LibRaw configuration and 3rd-party libraries used.
In general: LibRaw is for developers, not for end-users, provided samples are samples only to demonstrate LibRaw abilities.
Tried to test the functionality standalone, meanwhile measuring each function run time.
For Windows, the numbers are more or less the same, but for macOS, the same code runs 4 times slower with the 0.20.2 version.
The only function which has a significant time difference is `proc.dcraw_process()`, which as I said is 4 times slower than on the v19.2 version. The problem is reproducible only on macOS.
Yes, of course I understand the issue of partial support. But nevertheless it doesn't make sense to pass a raw to LibRaw for decoding when the camera's not supported. So while the camera list isn't perfect (and I do understand that), in the absence of any other means to make that determination, that's what I have to do.
Clearly if there's the possibility of a better solution that could be implemented in the future, I'd be very happy to use that.
I wrote the code to install the callback and the callback gets called when a RAW file is read. Now, from the callback, when the wanted tag is seen, how to I call the datastream read method to read the tag value. The call back receive a pointer to LibRaw_abstract_datastream input stream. The question is how the datastream read method is called from the callback code which is [equivalent to] C code and as such has to use LibRaw C-API. I don't see anything in LibRaw C-API to use a datastream.
That is not a question related to Delphi but related to LibRaw C-API.
The question is: Using LibRaw C-API, how to call the datastream reader to read an EXIF tag value from the exif parser callback.
Could you please provide specific file link, not entire archive?
See https://raw.pixls.us for samples. LibRaw stops w/
"Only Bayer-pattern RAW files supported, sorry...."
Recent Samsung DNGs are not CFA, but "enhanced" 3-channel LinerRaw (like recent Apple iPhone ProRAW), and w/ ljpeg compression using restart markers...
The discussion will only make sense if specific problematic files are included.
At the moment, we do not have a single example of a file from Samsung on which RAW data would not be unpacked by LibRaw.
Recent Samsung models started putting out the "less" normal DNGs - the ljpeg compression is not a single stream, but has restart markers, don't know if LibRaw supports that...
AFAIK, Samsung phones records more-or-less (*) normal DNG, so already supported
(*) some DNG files from latest Samsung devices contains incorrect thumnail data (while RAW data is OK)
This file looks damaged: it contents does not pass bounds checks in samsung3_load_raw; disabling this checks not results into correct image.
All other samples from Samsung NX500 camera we have are processed OK.
Use open_file() or open_buffer() and check the return code.
Thanks
LibRaw is dual-licensed (LGPL 2.1 and CDDL-1), I do not see any problems from our side to use LibRaw under the terms of one of these licenses.
Could you clarify what exactly is your question?
as per update policy: https://www.libraw.org/#updatepolicy
Yes, RawDigger relies on LibRaw imgdata.idata.filters to get CFA layout. Also, if LibRaw CFA pattern/layout detection is wrong it will result into a wrong rendering.
Sorry, no not know how Matlab uses LibRaw.
Dear Alex,
thank you for your swift reply. OK, I understand. I mainly use MATLAB (R2022a) -which uses LibRaw- but encountered the issue of not being able to open GPR files. That is why I started to delve into the LibRaw *.exe files. So I will wait until the next MATLAB release (R2023a). Maybe they then support GoPro's GPR files.
As for metadata, I use Exiftool extensively but found the MATLAB implementation of getting RAW metadata (again using LibRaw) faster than my code (which also needs to call Exiftool). However, for a Nikon P6000 file, the CFA layout delivered by MATLAB is different from the one given in Exiftool. And since I also have RAWdigger and see that the individual channels are displayed correctly, I wondered where the error comes from. That was my reason to ask if there would be a LibRaw *.exe file to extract metadata.
If it would be a LibRaw error, then RAWdigger would display the channels wrongly, I guess. But also a MATLAB error seems strange as they use LibRaw.
If you want, I could send you the file. Many thanks for what you do and for spreading your knowledge!
Cheers
What metadata you're asking for? Probably it is better to use exiftool for it.
Providing LibRaw binaries with 3rd-party decoders/decompressors compiled in (libjpeg, libdeflate/libz, libjasper, Adobe DNG SDK, GoPro SDK) may result into 3rd-party libraries version conflicts: for example LibRaw uses libjpeg-turbo, while calling applications is linked with standard jpeg libraries.
So, the developer who uses LibRaw should select LibRaw configuration and 3rd-party libraries used.
In general: LibRaw is for developers, not for end-users, provided samples are samples only to demonstrate LibRaw abilities.
Tested (w/ full recompile for both 0.19 and 0.21) and unable to reproduce.
dcraw_process() is only a glue for other functions in processing pipeline, please narrow your search to specific function or code lines.
Hi,
Tried to test the functionality standalone, meanwhile measuring each function run time.
For Windows, the numbers are more or less the same, but for macOS, the same code runs 4 times slower with the 0.20.2 version.
The only function which has a significant time difference is `proc.dcraw_process()`, which as I said is 4 times slower than on the v19.2 version. The problem is reproducible only on macOS.
Any thoughts about this?
Thanks in advance.
Hrach Martirosyan
Yes, of course I understand the issue of partial support. But nevertheless it doesn't make sense to pass a raw to LibRaw for decoding when the camera's not supported. So while the camera list isn't perfect (and I do understand that), in the absence of any other means to make that determination, that's what I have to do.
Clearly if there's the possibility of a better solution that could be implemented in the future, I'd be very happy to use that.
All the best
Counterquestion:
we list Nikon Z9 as
"Nikon Z 9 (HE/HE* formats are not supported yet)",
Is Z9 supported or not?
So what is the preferred method of determining if the camera is supported if not that.
Thanks
David
$exiftool -Make OM_Systems_OM1_RAW_Image_20mpx_P1010025.ORF
Make : OM Digital Solutions
As discussed many times on this forum pages, comparing camera name with LibRaw::cameraList() doesn't look like a good idea
To solve the issue of reading EXIF copyright data using the C-API, I added a simple function in libraw_c_api.c:
DllDef int libraw_datastream_read(void *ifp, void *ptr, size_t size, size_t nmemb) { if (!ifp) return -1; return ((LibRaw_abstract_datastream *)ifp)->read(ptr, size, nmemb); }Then from my application I can call that function from the exifparser callback installed using libraw_set_exifparser_handler.
Simple and easy.
Of course other similar functions may be added to call various LibRaw_abstract_datastream methods .
LibRaw datastreams are C++ objects.
I wrote the code to install the callback and the callback gets called when a RAW file is read. Now, from the callback, when the wanted tag is seen, how to I call the datastream read method to read the tag value. The call back receive a pointer to LibRaw_abstract_datastream input stream. The question is how the datastream read method is called from the callback code which is [equivalent to] C code and as such has to use LibRaw C-API. I don't see anything in LibRaw C-API to use a datastream.
Probably one will need to write some code (to install callback(s) and callback code itself)
That is not a question related to Delphi but related to LibRaw C-API.
The question is: Using LibRaw C-API, how to call the datastream reader to read an EXIF tag value from the exif parser callback.
Pages