Recent comments

Reply to: Build problem   6 months 1 week ago

The makefile for creation and linking did not change. This is how linking of the source code is defined:

$(TARGET_LIB): $(SOURCES) $(OBJS) $(LIBRAW_STATIC_LIB) Makefile
    $(CXX) $(LFLAGS) $(TARGET) $(OBJ_VECTOR) $(OBJ_COMPLEX) $(OBJ_WRAPPER)  $(LIBS)

This actually runs following command to link the collected object files (mixed C/C++) with static library libraw and create a dynamic library as target

    c++ -dynamiclib -o libSomeDynamicLib.jnilib [lot of object files]  -L"../LibRaw/lib/" -lraw

So the process of linking takes place, but the linker complains it cannot find the symbols in the created binary of 'libraw.a' at this stage. As if libraw binaries and the compiled sources from the project created different object binaries on the same machine and architecture (target machine currently is an Intel type MacBook Pro, x86_64), with all *.o files and libraries, or at least they do seem to have different method signatures.

Also I do not understand, why code segments are compiled into libraw, like DNG ore Kodak related stuff, if this is optional.

I tried to apply same compiler binaries and options to compile other projects *.cpp resources, but linking all created binaries against libraw still fails.

Again, I checked LibRaw's collected output of './configure', but cannot get insights why the binaries cannot be linked together:

checking for a BSD-compatible install... /usr/bin/install -c
checking whether sleep supports fractional seconds... yes
checking filesystem timestamp resolution... 2
checking whether build environment is sane... yes
checking for a race-free mkdir -p... mkdir -p
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking xargs -n works... yes
checking build system type... x86_64-apple-darwin23.6.0
checking host system type... x86_64-apple-darwin23.6.0
checking for g++... g++
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C++... yes
checking whether g++ accepts -g... yes
checking for g++ option to enable C++11 features... -std=gnu++11
checking whether make supports the include directive... yes (GNU style)
checking dependency style of g++ -std=gnu++11... gcc3
checking for gcc... gcc
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld
checking if the linker (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld) is GNU ld... no
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 786432
checking how to convert x86_64-apple-darwin23.6.0 file names to x86_64-apple-darwin23.6.0 format... func_convert_file_noop
checking how to convert x86_64-apple-darwin23.6.0 file names to toolchain format... func_convert_file_noop
checking for /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld option to reload object files... -r
checking for file... file
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ranlib... ranlib
checking for ar... ar
checking for archiver @FILE support... no
checking for strip... strip
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /bin/dd
checking how to truncate binary pipes... /bin/dd bs=4096 count=1
checking for mt... no
checking if : is a manifest tool... no
checking for dsymutil... dsymutil
checking for nmedit... nmedit
checking for lipo... lipo
checking for otool... otool
checking for otool64... no
checking for -single_module linker flag... ld: warning: -single_module is obsolete
no
checking for -no_fixup_chains linker flag... yes
checking for -exported_symbols_list linker flag... yes
checking for -force_load linker flag... yes
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... yes
checking for gcc option to produce PIC... -fno-common -DPIC
checking if gcc PIC flag -fno-common -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld) supports shared libraries... yes
checking dynamic linker characteristics... darwin23.6.0 dyld
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -std=gnu++11 -E
checking for ld used by g++ -std=gnu++11... /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld
checking if the linker (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld) is GNU ld... no
checking whether the g++ -std=gnu++11 linker (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld) supports shared libraries... yes
checking for g++ -std=gnu++11 option to produce PIC... -fno-common -DPIC
checking if g++ -std=gnu++11 PIC flag -fno-common -DPIC works... yes
checking if g++ -std=gnu++11 static flag -static works... no
checking if g++ -std=gnu++11 supports -c -o file.o... yes
checking if g++ -std=gnu++11 supports -c -o file.o... (cached) yes
checking whether the g++ -std=gnu++11 linker (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld) supports shared libraries... yes
checking dynamic linker characteristics... darwin23.6.0 dyld
checking how to hardcode library paths into programs... immediate
checking for OpenMP flag of C compiler... unknown
configure: WARNING: OpenMP support cannot be enabled because your system doesn't support it.
checking for jpeg_mem_src in -ljpeg... yes
checking for jpeglib.h... yes
checking for jas_init in -ljasper... no
configure: WARNING: libjasper not found
checking for pkg-config... /usr/local/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for zlib... yes
checking for lcms2... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating libraw.pc
config.status: creating libraw_r.pc
config.status: executing depfiles commands
config.status: executing libtool commands

This is the (sample) output during compilation of the sources of libraw:

libtool: compile:  g++ -std=gnu++11 -DPACKAGE_NAME=\"LibRaw\" -DPACKAGE_TARNAME=\"libraw\" -DPACKAGE_VERSION=\"0.21.3\" "-DPACKAGE_STRING=\"LibRaw 0.21.3\"" -DPACKAGE_BUGREPORT=\"info@libraw.org\" -DPACKAGE_URL=\"http://www.libraw.org\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_JPEGLIB_H=1 -I. -DUSE_JPEG -DUSE_JPEG8 -DUSE_ZLIB -I/usr/local/Cellar/little-cms2/2.16/include -DUSE_LCMS2 -g -O2 -MT src/decoders/decoders_libraw.lo -MD -MP -MF src/decoders/.deps/decoders_libraw.Tpo -c src/decoders/decoders_libraw.cpp  -fno-common -DPIC -o src/decoders/.libs/decoders_libraw.o
Reply to: Build problem   6 months 1 week ago

Sorry, but your huge quotes don't tell me anything at all, since all this happens within your build system, which I know nothing about.

Two short questions:
1) Do you build LibRaw via make -f Makefile.dist or via ./configure?
2) (in both cases): Does the LibRaw build result in compiled examples or not? (these examples are in ...LibRaw/bin/ folder if you're using provided Makefile.dist. They may be located somewhere else when configure is used)

Reply to: Build problem   6 months 1 week ago

Undefined symbols: LibRaw::open_file means "You've forgot to link with libraw library"

The second group of errors means: you've build libraw with JPEG decompression support but forgot to add libjpeg to your linker input.

Reply to: Build problem   6 months 1 week ago

Thanks again. I could solve the compile problems. Now, I'm getting a lot of undefined symbols when trying to link the library against my app. Most of them sound like the optional packages have been compiled into the library, now missing their references when linking against the static library for branch "LibRaw 0.21-stable", which sounds weird.

ld: Undefined symbols:
  LibRaw::open_file(char const*), referenced from:
      _Java_net_bwmc_libraw_LibRawImageLoader_loadRawImage in LibRawImageLoader.o

I tried to resolve this, by rolling back to version 0.20 and rebuild the library for this version, which previously worked. However, the list of undefined references I get while linking is even longer. Now, it sounds like optional libraries haven't been detected as optional when switching to branch "LibRaw 0.20-stable" and rebuilding after 'make clean'.

ld: Undefined symbols:
  LibRaw::open_file(char const*), referenced from:
      _Java_net_bwmc_libraw_LibRawImageLoader_loadRawImage in LibRawImageLoader.o
  _jpeg_CreateDecompress, referenced from:
      LibRaw::lossy_dng_load_raw() in libraw.a[9](dng.o)
      LibRaw::kodak_jpeg_load_raw() in libraw.a[13](kodak_decoders.o)
  _jpeg_abort_decompress, referenced from:
      LibRaw::lossy_dng_load_raw() in libraw.a[9](dng.o)
  _jpeg_destroy_decompress, referenced from:
      LibRaw::lossy_dng_load_raw() in libraw.a[9](dng.o)
      LibRaw::lossy_dng_load_raw() in libraw.a[9](dng.o)
      LibRaw::lossy_dng_load_raw() in libraw.a[9](dng.o)
      LibRaw::kodak_jpeg_load_raw() in libraw.a[13](kodak_decoders.o)
      LibRaw::kodak_jpeg_load_raw() in libraw.a[13](kodak_decoders.o)
  _jpeg_finish_decompress, referenced from:
      LibRaw::kodak_jpeg_load_raw() in libraw.a[13](kodak_decoders.o)
      LibRaw::kodak_jpeg_load_raw() in libraw.a[13](kodak_decoders.o)
  ...

I followed the instructions how to compile by executing these commands:

autoreconf --install
./configure
make

Also I tried 'make clean' and rebuild from scratch and removed many files manually, with no success.

Any suggestion how to solve this?

Reply to: Build problem   6 months 1 week ago

With default/unchanged Makefile.dist LibRaw requires zlib only (present in base macOS).

All additional dependencies (libjpeg, RawSpeed, Adobe DNG SDK) are optional and disabled by default.

Reply to: Build problem   6 months 1 week ago

Hi Alex,

Again, thanks for your quick support. I realized, that I had to update the whole brew installation on my mac and also install and upgrade a lot more tools and libraries, like automake or pkg-config, which is mentioned in an earlier post.

Also I had to install libraries, like jasper, or zlib. From a perspective of such an upgraded full fledged development machine, it is hard to judge, what libraries need to be provided with libraw bundled with an app on a plain macos end-user installation.

All dependencies (additional libraries) that are now compiled with libraw obviously do not exist on a barebone macos installation, esp. without additional development tools like XCode and additional add-ons installed using homebrew installation manager.

Is there a list of libraries (DLLs, share libs) that need to be provided together with any application that relies on libraw and not running in a full fledged development machine environment?

It would be a nightmare for a developer of collecting complaints from end-users that quickly refuse to use your app because its not running on a real world mac. :-)

Thanks,

Thilo

Reply to: Build problem   6 months 1 week ago

You need to either install autotools or just use make -f Makefile.dist
(adjust makefile to meet your needs: JPEG comression support, etc)

Reply to: Problem when emulating dcraw document mode   6 months 1 week ago

Thanks for your suggestions! I've decided to directly use the data in rawdata.raw_image. I've realized that the 1 discrepancy might just be a coincidence after testing different raw formats.

Reply to: Problem when emulating dcraw document mode   6 months 1 week ago

And specific followup: there is no document mode in LibRaw::dcraw_process (and dcraw_emu), if you want to get something close, then an exact match of values ​​is not guaranteed with parameters your specified or any other parameter values (in addition to the fact that the black level may differ in some cases)

Reply to: Problem when emulating dcraw document mode   6 months 1 week ago

dcraw -D is 'totally RAW, no scaling'

Just skip processing and use raw data from imgdata.rawdata.raw_image (or color3_image,color4_image).

samples/unprocessed_raw.cpp sample is probably what you're looking for.

Reply to: Add simplest debayer support (superpixel)   7 months 2 weeks ago

Followup: could you please share some file sample(s) to check if metadata extracted correctly or not

Reply to: Add simplest debayer support (superpixel)   7 months 2 weeks ago

LibRaw is about RAW data and metadata extraction.

Existing postprocessing code is intended mostly for testing purposes, there is no plans to improve it.

This is clearly stated on this site main page.

Reply to: open_file return -100009 : when path contains french e accent   7 months 3 weeks ago

Hello Alex !
Thank you for your help.

To make my project LibRaw work (QT / Windows 10) with last release Libraw 0.21.2 and Unicode,
i added these 3 lines in the file libraw.h before compiling Librairy.

# define LIBRAW_WIN32_CALLS
# define __INTEL_COMPILER
# define LIBRAW_WIN32_UNICODEPATHS

May be one or two #define are required for my computer.
So i can open Raw file with a filename QString (16bits)

const wchar_t *array = (const wchar_t*)filename.utf16();
int ret = this->processor->open_file( array) ;
if( ret != LIBRAW_SUCCESS )
return false ;

Best regards,

Luciano

Reply to: open_file return -100009 : when path contains french e accent   7 months 3 weeks ago

>> I tried various conversions

The wchar_t* string is passed directly to Win32/CreateFileW

So, if you're able to use other Win32 file API calls, it should work for LibRaw too.

UPD: on modern windows, all interfaces are unicode already, starting from wmain/_tmain program 1st function, so there is no need to convert anything from/to 8-bit strings.

Reply to: r5 mark II support   7 months 3 weeks ago

Our update/release schedule policy is provided on this site homepage: https://www.libraw.org/#updatepolicy

We know nothing about darktable update schedule.

Reply to: Do I need to use dcraw_* api ?   8 months 1 week ago

LibRaw's goal is to read RAW data and metadata, as explained on this site 1st page: https://www.libraw.org/

Postprocessing is indeed imported from dcraw, there is no other postprocessing in LibRaw.
If one want to process RAW data in own code: LibRaw::open_file()/unpack() is enough for that.

Reply to: Do I need to use dcraw_* api ?   8 months 1 week ago

Just looking for a quick comment on what is gained using the non-dcraw API. I have read through most of the documentation and it seems to me that they can achieve similar functionality. I get the impression that the libraw dcraw API was meant to ease migration efforts from the original dcraw.

I don't see an inherent benefit between the two methods reading the the documentation, which is why I'm curious.
I suspect if I were using more of libraw's processing tools it would make sense to use the non-dcraw api, but I'd like to confirm that.

Reply to: Do I need to use dcraw_* api ?   8 months 1 week ago

Do you have a specific question or do you asking to re-tell the entire documentation in other words?

Reply to: Do I need to use dcraw_* api ?   8 months 1 week ago

I wasn't sure if the other methods are perhaps faster or have better support. I just want to make sure I understand what options exist and why I would use one over the other.

Reply to: Do I need to use dcraw_* api ?   8 months 1 week ago

If everything works for you and you are happy with the result, what else do you want to improve?

Reply to: If I have bayer data, how to process it to get the image?   10 months 3 weeks ago

and, also, samples/unprocessed_raw sample

Reply to: If I have bayer data, how to process it to get the image?   10 months 3 weeks ago

Thanks for the info.

I've another question which is the other way around:

Can I decompress a compressed Fuji RAF file and get the uncompressed X-Trans sensor data buffer from LibRaw?

Do I call unpack() and then get the uncompressed sensor data from somewhere?

Is it in rawProcessor.imgdata.rawdata?

Reply to: LibRaw with Adobe DNG SDK 1.7   10 months 3 weeks ago

I've tried all the options that could make a difference, but there are not that many options in the Librarian when compiling LibRaw as a static lib.

I've settled to compile LibRaw with Ox instead O2 and that works just fine. Maybe it's a tick slower than it could, but I think it's fine.

Do you have a big spam problem? The post form always tells me to take more time filling the form. Maybe I type too fast ;-)

Reply to: LibRaw with Adobe DNG SDK 1.7   10 months 3 weeks ago

This is not string pooling, this should be linker identical code folding (designed to merge same methods of different classes, e.g. templates)
So, two originally different function pointers are the same in the optimized code.

We'll return to this but not immediately

Pages