Recent comments

Reply to: Quesiton about "output_color=0"   5 years 6 months ago

There are a lot of different RAW formats (data formats, metadata formats, metadata values), it's pretty hard to discuss them all at once.

In general, you may assume that unpack() provides linear data/black level not subtracted.

Reply to: Quesiton about "output_color=0"   5 years 6 months ago

Thanks, Alex!

If the camera records raw in linear space, there must be a way to know it during "unpack()" stage, correct? is it indicated somewhere in the meta data of the RAW file?

Reply to: Quesiton about "output_color=0"   5 years 6 months ago

LibRaw applies (some) linearization data on unpack() phase.

Reply to: Quesiton about "output_color=0"   5 years 6 months ago

Thanks a lot!

Just wondering if some camera actually record raw data in linear space? If that is true, can “libraw” tell us if the raw data is already in linear space?

Reply to: Quesiton about "output_color=0"   5 years 6 months ago

White balance is, in most cases, applied to linear data, so linearization is done before white balance. Traditional approach to demosaicking is also to apply it to linear data, so linearization quite often precedes demosaicking. That makes linearization the first step of raw processing.

Reply to: Quesiton about "output_color=0"   5 years 6 months ago

Hi Alex,

Just wondering where the "Linearization" stands during "raw processing"?

Thanks a lot,

Mio

Reply to: CR3 support   5 years 6 months ago

As soon as we'll able to decode it.

Any help is highly appreciated.

Reply to: what are derived d65 multipliers?   5 years 6 months ago

LibRaw allows to set any white balance, including the ones that comes from camera metadata (use imgdata.params.user_mul[] for that).

Reply to: what are derived d65 multipliers?   5 years 6 months ago

the question was a two-parter.

first: "So when you say daylight colour profile, its a preset that comes with libraw vs what the camera thinks it should be?"

Second, if there is no way to correctly white balance to 6500k, then why do we even have these numbers to begin with?

There are other reasons for wanting to get a correct d6500 white balance than matching a physical lamp. For example if i have to work with raw files from several cameras: then if they could all reliably be set to a 6500k white balance, they would at least all match eachother regardless of the actual lamp temperature, saving one self the work of having to grade each camera individually.

Also look at the rawtoaces project. it is specifically made to convert raw files to aces colourspace which is calibrated around a 6000k (?) whitepoint. Unfortunately not all cameras have had their sensors analysed for spectral sensitivity.

Reply to: what are derived d65 multipliers?   5 years 6 months ago

Your question is 'is there any reason the derived values should be more correct....'
My question is: 'more correct for WHAT?'

Real scene is lit by some real (daylight) light source, not (imaginary/synthetic) black body at 6500K.
Both settings are 'not correct' for real image/real scene.

Reply to: what are derived d65 multipliers?   5 years 6 months ago

sorry but that doesn't really answer the question

Reply to: what are derived d65 multipliers?   5 years 6 months ago

Unless your scene is lit by exact D65 (imaginary) light source, both values are 'not correct'

Reply to: what are derived d65 multipliers?   5 years 6 months ago

So when you say daylight colour profile, its a preset that comes with libraw vs what the camera thinks it should be? is there any reason the derived values should be more correct than the makernote values?

Reply to: what are derived d65 multipliers?   5 years 7 months ago

Derived D65 multipliers are calculated from daylight color profile, while makernotes multipliers are recorded by camera.

Reply to: Libraw 0.19 crashes on macOS if used in a background thread   5 years 7 months ago

Thank you for confirming that.

Yes, LibRaw(0.19) object is significantly larger than (0.18). Looks like we need to move curve[0x1000] to dynamic allocation to save stack.

Reply to: Libraw 0.19 crashes on macOS if used in a background thread   5 years 7 months ago

It was a stack problem. The memory footprint must have changed from 0.18.x to 0.19.
So, please close the issue.

Reply to: Libraw 0.19 crashes on macOS if used in a background thread   5 years 7 months ago

There is very similar report related to digiKam: https://github.com/LibRaw/LibRaw/issues/186

Quote from my last reply in that thread:
1st: the backtraces points to LibRaw::LibRaw (constructor), so the problem is not related to any specific RAW file

2nd: I've tried XCode 6, XCode 8, XCode 9 builds (using make -f Makefile.dist) and was unable to reproduce the problem using both dcraw_emu (single thread) and half_mt (multithreaded). Both samples works fine with DSC_1796.NEF sample (link above). The sample was multiplied into many (same) files: DSC_1796-[0-9].NEF

So, I'm still suspect that this is not LibRaw problem, but not enough stack problem. LibRaw objects are big (e.g. several 16-bit curves), so default stack size could be not enough (it is better to allocate LibRaw object dynamically to avoid that).

Is there any way to see is enough stack space is present [in your app]?

Reply to: libraw wide char format support on MSYS2   5 years 7 months ago

OK, I got it. Thank you.

Reply to: libraw wide char format support on MSYS2   5 years 7 months ago

Makefile.mingw already defines -DLIBRAW_NODLL, so disabling DllDef (and, of course, DLL builds):

DllDef is defined in libraw_types.h:
#ifdef WIN32
#ifdef LIBRAW_NODLL
#define DllDef
#else
#ifdef LIBRAW_BUILDLIB
#define DllDef __declspec(dllexport)
#else
#define DllDef __declspec(dllimport)
#endif
#endif
#else
#define DllDef
#endif

Reply to: libraw wide char format support on MSYS2   5 years 7 months ago

Sorry I think I misunderstood.
The problem is because the error I cannot compile the lib to test it. I thought you told me by removing the flag it would be ok.
Sorry,

Reply to: libraw wide char format support on MSYS2   5 years 7 months ago

I can not understand the question. What feature you want to disable?

Reply to: libraw wide char format support on MSYS2   5 years 7 months ago

Also, I took a look to the code of libtiff that is also included in msys2:

#ifdef __WIN32__
#include <windows.h>
/*
 * Open a TIFF file with a Unicode filename, for read/writing.
 */
TIFF*
TIFFOpenW(const wchar_t* name, const char* mode)
{
	static const char module[] = "TIFFOpenW";
	int m, fd;
	int mbsize;
	char *mbname;
	TIFF* tif;
 
	m = _TIFFgetMode(mode, module);
	if (m == -1)
		return ((TIFF*)0);
Reply to: libraw wide char format support on MSYS2   5 years 7 months ago

OK thanks. Can I disable that ?

Reply to: libraw wide char format support on MSYS2   5 years 7 months ago

Makefile.mingw builds LibRaw with -DLIBRAW_NODLL, so DllDef is defined empty

Reply to: libraw wide char format support on MSYS2   5 years 7 months ago

OK I will try to investigate, but I tried to compile libraw on MSYS2 with no sucess.

I've a lot of

src/libraw_c_api.cpp:373:14: warning: 'int libraw_get_iwidth(libraw_data_t*)' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]
src/libraw_c_api.cpp:380:16: error: function 'float libraw_get_cam_mul(libraw_data_t*, int)' definition is marked dllimport
   DllDef float libraw_get_cam_mul(libraw_data_t *lr, int index)

Pages