Recent comments

Reply to: MinGW-64 build and UNICODE paths   7 years 8 months ago

You may implement own datastream (e.g. based on LibRaw_bigfile_datastream which uses FILE* I/O) and own open_wfile() method.

Reply to: MinGW-64 build and UNICODE paths   7 years 8 months ago

I found std::filebuf usage later. So, it looks like there is no easy way to handle Unicode paths in mingw64 builds :(.

Reply to: Sensor temperature?   7 years 8 months ago

Windows binaries are available from exiftool site: http://www.sno.phy.queensu.ca/~phil/exiftool/

Mac and linux 'binaries' are just perl scripts (with lot of perl libraries). In RawDigger/Mac we store this script/libs in app resource folder.

Reply to: Sensor temperature?   7 years 8 months ago

Great! If I can provide the binary, it's fine then. I never used QProcess, but I'll find out. Thanks Alex!

Reply to: Sensor temperature?   7 years 8 months ago

You use Qt library. It is very easy to use QProcess wrapper to run exiftool (make sure you've closed raw file handle in Windows to allow access, LibRaw::recycle_datastream() do that, keeping all parsed data in memory).

We supply exiftool binary with our RawDigger software, exiftool's license permits this.

Reply to: Sensor temperature?   7 years 8 months ago

Ok, I understand that it would cumbersome to maintain such feature. I will give it a try to either exiv2 or exiftool. The problem with using a command line output is that it would make me digress a bit from my software intended design. So far I manage to have things work in Windows, Mac and Linux without any hassle but dealing with exiftool command line will break things out of my software, and maybe forcing the user to install exiftool too?...
exiv2 seems to allow to keep things more internal.

Reply to: Sensor temperature?   7 years 8 months ago

When adding additional metadata parse to libraw we need to support most major camera vendors (C,F,L,N,O,P,P,S,S). Unfortunately vendor specific metadata (makernotes) is not documented and may change in format from camera to camera (even from one firmware version to another).

So we support only metadata that is absolutely necessary for common photographic processing.

For your needs you may also use call to external exiftool program and parse output (command line like exiftool -cameratemperature -csv _81E0220.CR2 ). It is easy to implement and exiftool license is free to do that.

Reply to: Request for software names   7 years 8 months ago

Hi,

Since 1.5 year I started developing yet another software for astrophotography called "LightDrops". It's still a modest project but I hope it will grow. It's hosted in Github for now: https://github.com/raphaelattie/LightDrops

I'm not a professional software developer, but a solar physicist and astronomer who learned programming on the job. In this project I am being helped by a professional software developer who has taught me the basic principles of software development, just enough to get me started with this project. I aim at uniting simplicity, scientific precision and efficiency, which are often mutually exclusive in our realm. Libraw is essential in the development of this software and I thank the development team for making it available. Don't hesitate to share ideas for this project, should you have any.

Thanks

Reply to: Sensor temperature?   7 years 8 months ago

Thanks, I will have a look, this could solve my problem for now. Nonetheless it would be ideal to have this information from within Libraw. In the context of astrophotography, DSLRs get modified sometimes with an inconvenient external display linked to another inner temperature sensor (with extra cost) whereas this information could easily be displayed for monitoring temperature evolution of the electronics by using the existing sensor that throws this information in the raw file or exif data. This would make the management of dark files much sensible and easier. Indeed, sometimes we take a shot at the same temperature as some other night, for which we already have a dark file, or, knowing the two different temperature of two different dark files, we can interpolate a new dark file at the missing temperature, or we just want to characterise the temperature dependance of the noise. It's just a suggestion, but it would be a very nice feature for a future update, it will spare the trouble of adding yet another library to get this extra bit of information.

Reply to: Sensor temperature?   7 years 8 months ago

there is exiv2 library: http://www.exiv2.org/

Also, you may install own exif parser callback to be called on each EXIF tag.

Reply to: Sensor temperature?   7 years 8 months ago

I didn't know about such tools to get EXIF info programmatically, apart from what Libraw does. Can you recommend one in either C or C++?

Thanks

Reply to: Sensor temperature?   7 years 8 months ago

There is no special data field/parsing code for this data in libraw.

For cameras with temperature data stored in EXIF fields (panasonic/leica, for example) you may install own EXIF parser callback to get this data.

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

Thank you :)

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

and checked: dcraw_emu -q 1 works fine with your sample

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

And here it is: https://github.com/LibRaw/LibRaw/commit/8a8723b0da66f8d858d93c23f2aeda26...

It is against 'already patched' version

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago
OK.

OK.

Glad to see that it will be fixed.

Thank you.

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

Sorry, current public snapshot contains this broken patch. To be reverted today

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

LibRaw 0.17.2 (official release from this site) do not have this bug (not crashes on VNG), but do not compile with gcc6.
If someone uses (broken) 3rd party patch - we're not responsible for that.

LibRaw 0.18-201610xx (i expect next public snapshot in october or so) will both compile by gcc6 and will do VNG :)

Current libraw 0.18 public snapshot (this is not release!) from https://github.com/LibRaw/LibRaw is the same as LibRaw 0.17.2: no patch, no bug, no gcc6 compile

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

Thank you so much for your answer.

The most important thing I do not want is that the patched library is released on a long term support system.
But it seems ok for that because Ubuntu 16.04 is using 0.17.1. However, next Ubuntu will have this problem I think: https://launchpad.net/ubuntu/yakkety/+source/libraw because they apparently use same sources than testing.

0.18 should fix it ? If yes no problem for me, I will wait. But users with Ubuntu 16.10 will probably crash, except if someone patch the 0.17.2 to fix the bug. So after that we can ask to Ubuntu dev's team to fix the package.

Thanks again

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

And followup again.
Here is the patch: https://github.com/LibRaw/LibRaw/commit/eba7a66e23f2f62cc4c8115af8066f2d...

So, if in your copy of libraw/internal/dcraw_common.cpp
vng_interolate() code starts with:

  struct interpolate_terms {
    signed char y1, x1, y2, x2, weight;
    unsigned char grads;
  };

than your libraw copy is indeed patched by this wrong patch.
Do not use VNG (and use patched library), or do not use gcc6 (and use unpatched library), or wait for autumn LibRaw-0.18 public snapshot (or, may be, 0.18-release)

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

followup: I'm unable to find right branch/tag in debian repo. Master branch is unchanged LibRaw 0.17.2, so it should work with DNG, but will not compile with gcc6.

Looks like you use some specific tag/branch?

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

LibRaw 0.17 (and before) known to be not compilable by gcc6. So if you're using gcc6 and it builds OK, it means you use some modified source.

The patch proposed by community brokes 4-color processing in vng_interpolate. meanwhile, it looks like Debian community use this patch for debian repo: https://github.com/LibRaw/LibRaw/issues/56

(And, yes, they know that the patch is broken, see discussion in github issue thread)

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

Mmh you would say that the version in repository is not exactly the one in your git repository ? But a patched one ?

Apparently we can fetch debian sources here: https://anonscm.debian.org/cgit/pkg-phototools/libraw.git/
But I am a bit lost in debian git repository.

Reply to: Is there a known regression in 0.17 ?   7 years 8 months ago

could you please provide exact git command line to fetch exactly the branch you use?
Debian repo (tag system) is unknown for me, so I do not know what tag i need to fetch.

Most likely, debian people has used bad patch from libraw-0.18 (for gcc6 compatibility). This patch (circulating around internet) broke vng interpolation code (but makes libraw source compatible with gcc6)

Pages