Recent comments

Reply to: LibRaw 0.20 supported cameras   4 years 10 months ago

Do you have a schedule for this?

Reply to: LibRaw 0.20 supported cameras   4 years 10 months ago
yes

yes

Reply to: LibRaw 0.20 supported cameras   4 years 10 months ago

Is it planned to support the Canon EOS R?

Reply to: CR3 support   4 years 10 months ago
Reply to: Processing Fuji raw_image   4 years 10 months ago

Is there a getter for libraw_internal_data.unpacker_data.fuji_layout or will I need to sub-class to get at that?

I found is_fuji_rotated() which returns libraw_internal_data.internal_output_params.fuji_width

Thanks

Reply to: Processing Fuji raw_image   4 years 10 months ago

Yes, this is right piece of code

Reply to: Processing Fuji raw_image   4 years 10 months ago

I couldn't locate the exact version I'm using in github (I'm using version 18.8) The code in question reads as follows:

    // Move saved bitmap to imgdata.image
    if( imgdata.idata.filters || P1.colors == 1)
      {
        if (IO.fuji_width) {
          unsigned r,c;
          int row,col;
          for (row=0; row < S.raw_height-S.top_margin*2; row++) {
            for (col=0; col < IO.fuji_width << !libraw_internal_data.unpacker_data.fuji_layout; col++) {
              if (libraw_internal_data.unpacker_data.fuji_layout) {
                r = IO.fuji_width - 1 - col + (row >> 1);
                c = col + ((row+1) >> 1);
              } else {
                r = IO.fuji_width - 1 + row - (col >> 1);
                c = row + ((col+1) >> 1);
              }
              if (r < S.height && c < S.width)
                imgdata.image[((r)>>IO.shrink)*S.iwidth+((c)>>IO.shrink)][FC(r,c)]
                  = imgdata.rawdata.raw_image[(row+S.top_margin)*S.raw_pitch/2+(col+S.left_margin)];
            }
          }
        }
Reply to: Processing Fuji raw_image   4 years 10 months ago

We do not have any plans to drop SuperCCD support:
- raw data is extracted as is (in two subframes), keeping sensor aspect ratio
- processing is adopted from dcraw

Also, we do not have any plans to improve processing part, our goal is raw data and metadata extraction.

Reply to: Processing Fuji raw_image   4 years 10 months ago

I do not know what exact version you use. Could you please use github URLs with #l[lineno] markers in URL to point to exact version/exact line.

Reply to: Processing Fuji raw_image   4 years 10 months ago

Just to be sure, can you confirm that the code at line 2783 in libraw_cxx.cpp is the relevant code?

Thanks

Reply to: Processing Fuji raw_image   4 years 10 months ago

Please don't drop Fujitsu Super-CCD support, if that's done, people who use my software won't be able to reprocess old images (which the astrophotography folks often do).

I'll take a look at raw2image_ex() to see I can understand it.

Dave

Reply to: Processing Fuji raw_image   4 years 10 months ago

Yes, Fuji Super-CCD is completely different.
Look into raw2image_ex() source for details.

BTW, today, in 2019, it is good enough idea to drop Super-CCD support.

Reply to: color.maximum and camera white level   4 years 11 months ago

AFAIK, this is vendor-specified value for white point.

Reply to: color.maximum and camera white level   4 years 11 months ago

It's great that you get it from the CR2 file, but you didn't answer my question - does it represent the "white level" or not? And as an aside is it normal to see pixel values > that level?

Reply to: color.maximum and camera white level   4 years 11 months ago

For Canon cameras, imgdata.color.maximum is set by metadata provided by vendor in CR2 file.

Not doing so results in 'pink highlights' problem.

Reply to: Reproduce RawDigger result with LibRaw   4 years 11 months ago

By default, LibRaw *uses* DNG color matrix, quote from docs:

1 (default): use embedded color profile (if present) for DNG files (always); for other files only if use_camera_wb is set;

RawDigger settings are different:
0 for 'built-int color profile'
3 for 'Embedded in RAW'

Reply to: Reproduce RawDigger result with LibRaw   4 years 11 months ago

Thanks for your response!
Yes, I thought RawDigger used LibRaw.

I set no_auto_bright = 0, and it didn't really change the result. The LibRaw output is still much darker than the RawDigger output.

Are there any other settings I should be changing in LibRaw?

(Again, I suspect LibRaw is not using the DNG color matrix, but I'm not sure...)

Reply to: IsCameraSupported() ?   4 years 11 months ago

This is (list of) 'surely supported' (tested) ones.

UPD: published 'just for information', LibRaw does not use this list internally.

Reply to: IsCameraSupported() ?   4 years 11 months ago

Come on - you know what the word supported means as do I - after all you publish as list of supported cameras!

Reply to: IsCameraSupported() ?   4 years 11 months ago

Could you please define 'supported' ?

Reply to: IsCameraSupported() ?   4 years 11 months ago

I am checking the libraw open_file() and unpack() return codes - what warning field are you referring to? I looked the possible values for imgdata.process_warnings but none of those suggest a "camera not supported" condition.

Looking at the errors that are potentially returned (apart from LIBRAW_FILE_UNSUPPORTED which might be returned for a Canon .CR3 file until you add that support), I still don't see anything to tell me a camera isn't supported.

Thanks

Reply to: IsCameraSupported() ?   4 years 11 months ago

process_warnings - none of those conditions appear to tell me that a camera isn't supported, or should I interpret any value in process_warnings to indicate that the camera isn't supported?

Reply to: IsCameraSupported() ?   4 years 11 months ago
Reply to: IsCameraSupported() ?   4 years 11 months ago

There is no such call.

Check open_file/unpack return code(s) and/or warning field.

Pages