Add new comment

NarrowedType fixes for Clang

Hey,

I've was having some trouble compiling LibRaw a few months ago with LibRawLite using clang on OSX.

The source of the issue was incorrect sized types in internal/dcraw_common.cpp

The following errors were being thrown:

Constant expression evaluates to 128 which cannot be narrowed to type 'signed char'

Constant expression evaluates to 136 which cannot be narrowed to type 'signed char'

Constant expression evaluates to 65535 which cannot be narrowed to type 'short'

And with a c++11 target:
Invalid suffix on literal; C++11 requires a space between literal and identifier

I've created a patch for LibRaw to fix these issues on github here:
https://github.com/LibRaw/LibRaw/pull/45

Forums: